Skip to content

iOS wrapper: Add functionality of encoding binary data into Barcodes #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 19, 2023
Merged

iOS wrapper: Add functionality of encoding binary data into Barcodes #635

merged 5 commits into from
Oct 19, 2023

Conversation

alexmanzer
Copy link
Contributor

@alexmanzer alexmanzer commented Oct 17, 2023 •
edited
Loading

This is the iOS addition for the previous pull request from @markusfisch (#628) to be able to use the functionality of encoding binary data into Barcodes like DataMatrix.

Usage from swift will then be like:

let rawData = Data(base64Encoded: "VEVTVDEyMzQ=")!

let zxWriter = ZXIBarcodeWriter()
let cgImage = try? zxWriter.writeBytes(rawData, width: 500, height: 500, format: .DATA_MATRIX)

Alexander Manzer added 2 commits October 17, 2023 17:16
Add functionality of encoding binary data into DM
d3afeb6
Fix debug print in demo project
bc5d28e 
... and by the way correct also the new prototype function
@alexmanzer alexmanzer mentioned this pull request Oct 17, 2023
Merged
axxel
axxel requested changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@axxel axxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Alexander Manzer added 3 commits October 18, 2023 13:50
Merge branch 'master' into ios_datamatrix_use_encoding
cc394e8 
# Conflicts:
#	wrappers/ios/Sources/Wrapper/Writer/ZXIBarcodeWriter.mm
Rename methods to writeText and writeBytes
ec5317d 
... and integrate some other feedback
Removing the temporarily used buffer
34d0f3d
@alexmanzer
Copy link
Contributor Author

@axxel From my point of view, everything is now done.
If you agree, I would suggest a squash commit to avoid having all the fedback rounds and corrections on the master. But I'm almost sure that's what you would have done anyway.

@axxel
Copy link
Collaborator

axxel commented Oct 18, 2023

@benjohnde are you using the Writer-API of the iOS Wrapper? If so, am I right that you would find the amount of work caused by the write -> writeText renaming acceptable? ;)

@benjohnde
Copy link
Contributor

@axxel only using read :)

@axxel axxel merged commit bf06236 into zxing-cpp:master Oct 19, 2023
@alexmanzer alexmanzer deleted the ios_datamatrix_use_encoding branch October 19, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axxel axxel axxel requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexmanzer @axxel @benjohnde
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy