Skip to content

cmake: allow overriding python install directories #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2024
Merged

cmake: allow overriding python install directories #842

merged 1 commit into from
Oct 6, 2024

Conversation

jameshilliard
Copy link
Contributor

We may need to override these variables otherwise the python library may not get installed to the right location.

@jameshilliard
cmake: allow overriding python install directories
13130ef 
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
@axxel
Copy link
Collaborator

axxel commented Oct 6, 2024

Question: why not simply use cmake -DCMAKE_INSTALL_PREFIX=... to direct your installation to where you want it?

@jameshilliard
Copy link
Contributor Author

Question: why not simply use cmake -DCMAKE_INSTALL_PREFIX=... to direct your installation to where you want it?

AFAIU using that would change the install location of the non-python targets which would not be desired.

@axxel
Copy link
Collaborator

axxel commented Oct 6, 2024

AFAIU using that would change the install location of the non-python targets which would not be desired.

That is correct. So are you actually installing not only the python module but also the c++-lib / example binaries? I'm curious: what is your use case? Packaging for some distribution?

@jameshilliard
Copy link
Contributor Author

jameshilliard commented Oct 6, 2024 •
edited
Loading

So are you actually installing not only the python module but also the c++-lib / example binaries?

Yes.

Packaging for some distribution?

Yes, for buildroot.

@axxel axxel merged commit 8a9111b into zxing-cpp:master Oct 6, 2024
18 checks passed
@jameshilliard jameshilliard deleted the override-python-install branch October 7, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameshilliard @axxel
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy