Make ZXingReaderTest dependent on ZXingWriterTest #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ZXingReaderTest sometimes fails, because it implicitly depends on the ZXingWriterTest, as it needs the test.png created from this test. This fix tells cmake explicitly that the ZXingReaderTest depends on the ZXingWriterTest. This ensures that these unit tests are being executed sequentially even when using ctest with the -j flag.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you add zxing-cpp as a submodule to a repo that is automatically tested via CI/CD the ZXingReaderTest may fail when its being executed beofre the ZXingWriterTest. Locally this rarely happens because when it successfully ran once, the necessary test.png is always there.
This pull request fixes this issue by making the ZXingReaderTest dependent on the ZXingWriterTest in the CMakeLists.txt.