Page MenuHomePhabricator
Create Task
Maniphest T225144

Flagged Revs configuration may be broken
Closed, ResolvedPublic
Actions

Description

Sorry for the last minute addition of this... I didn't expect quite so much random issues going on

Basically, in an improvement to ongoing maintenance, Flagged Revs configuration may be broken in various ways on various wikis.... If it is, can people please report this to phabricator, and we'll get it remedied ASAP

Details

SubjectRepoBranchLines +/-
Move all FR config to an extension functionoperations/mediawiki-configmaster+722 -796
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Jun 5 2019, 7:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2019, 7:57 PM
Reedy changed the task status from Open to Stalled.Jun 5 2019, 8:44 PM

Maybe not needed now...

Quiddity subscribed.Jun 6 2019, 9:55 PM
Quiddity moved this task from To Triage to In current Tech/News draft on the User-notice board.Jun 6 2019, 10:20 PM
Jdforrester-WMF added a project: Wikimedia-Site-requests.Jun 6 2019, 10:23 PM
Wargo subscribed.Jun 8 2019, 1:33 PM
• matmarex subscribed.Jun 10 2019, 7:06 PM

For future reference, this is presumably due to migration to ext. registration: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/514508

I'm aware of one issue that was reported recently: T225276: FlaggedRevs (statistics) first three namespaces are listed twice. Can you look into that?

• matmarex added a subtask: T225276: FlaggedRevs (statistics) first three namespaces are listed twice.Jun 10 2019, 7:06 PM
• matmarex added a subtask: T225414: File namespace added to FlaggedRevs common configuration.
Reedy changed the task status from Stalled to Open.Jun 10 2019, 7:27 PM
Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Jun 10 2019, 8:19 PM
Reedy reopened subtask T225414: File namespace added to FlaggedRevs common configuration as Open.Jun 10 2019, 8:35 PM
94rain subscribed.Jun 12 2019, 12:54 PM
TerraCodes added a subtask: T225797: Remove FlaggedRevs-related user groups from all FlaggedRevs wikis that shouldn't have them.Jun 21 2019, 12:11 AM
Urbanecm added a subtask: T226054: FlaggedRevs disabled for NS "Wikisource", "MediaWiki" and "File" but it still requiring reviews for transcludes.Jun 21 2019, 5:01 PM
Urbanecm subscribed.Jun 21 2019, 5:16 PM
In T225144#5247888, @matmarex wrote:

For future reference, this is presumably due to migration to ext. registration: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/514508

Why would that affect production? Apparently we're still on wmf.8, and 57c1ae0 didn't make it into wmf.8. There's still extension-wip.json instead of extension.json.

Reedy added a comment.Jun 21 2019, 5:18 PM
In T225144#5274376, @Urbanecm wrote:
In T225144#5247888, @matmarex wrote:

For future reference, this is presumably due to migration to ext. registration: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/514508

Why would that affect production? Apparently we're still on wmf.8, and 57c1ae0 didn't make it into wmf.8. There's still extension-wip.json instead of extension.json.

We still wfLoadExtension() the wip json file

Urbanecm added a comment.Jun 21 2019, 5:25 PM

Thanks

Urbanecm added a comment.Jun 22 2019, 6:41 PM
In T225144#5247888, @matmarex wrote:

For future reference, this is presumably due to migration to ext. registration: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/514508

I'm aware of one issue that was reported recently: T225276: FlaggedRevs (statistics) first three namespaces are listed twice. Can you look into that?

I've investigated the cause of T225797, it's definitely due to ext. registration. See T225797#5276094 there.

gerritbot added a comment.Jun 22 2019, 9:32 PM

Change 518396 had a related patch set uploaded (by Reedy; owner: Reedy):
[operations/mediawiki-config@master] Move all FR config to an extension function

https://gerrit.wikimedia.org/r/518396

gerritbot added a project: Patch-For-Review.Jun 22 2019, 9:32 PM
gerritbot added a comment.Jun 24 2019, 1:46 PM

Change 518396 merged by jenkins-bot:
[operations/mediawiki-config@master] Move all FR config to an extension function

https://gerrit.wikimedia.org/r/518396

Stashbot added a comment.Jun 24 2019, 1:50 PM

Mentioned in SAL (#wikimedia-operations) [2019-06-24T13:50:54Z] <reedy@deploy1001> Synchronized wmf-config/flaggedrevs.php: T225144 T225276 T225414 T225776 T225797 T226054 (duration: 00m 56s)

Stashbot mentioned this in T225276: FlaggedRevs (statistics) first three namespaces are listed twice.Jun 24 2019, 1:50 PM
Stashbot mentioned this in T225414: File namespace added to FlaggedRevs common configuration.
Stashbot mentioned this in T225776: FlaggedRevs: Disable sysop protection level on the English Wikipedia.
Stashbot mentioned this in T225797: Remove FlaggedRevs-related user groups from all FlaggedRevs wikis that shouldn't have them.
Stashbot mentioned this in T226054: FlaggedRevs disabled for NS "Wikisource", "MediaWiki" and "File" but it still requiring reviews for transcludes.
Maintenance_bot removed a project: Patch-For-Review.Jun 24 2019, 2:10 PM
JJMC89 added a subtask: T226410: In de.wiktionary admins (again!!) no longer can grant the right for "autoreview" (passiver Sichter) or "editor" (Sichter)..Jun 24 2019, 3:03 PM
Udo_T subscribed.Jun 24 2019, 3:44 PM
Reedy closed subtask T226410: In de.wiktionary admins (again!!) no longer can grant the right for "autoreview" (passiver Sichter) or "editor" (Sichter). as Resolved.Jun 24 2019, 5:11 PM
Reedy closed subtask T226054: FlaggedRevs disabled for NS "Wikisource", "MediaWiki" and "File" but it still requiring reviews for transcludes as Resolved.Jun 24 2019, 5:12 PM
Reedy closed subtask T225797: Remove FlaggedRevs-related user groups from all FlaggedRevs wikis that shouldn't have them as Resolved.
Reedy closed subtask T225776: FlaggedRevs: Disable sysop protection level on the English Wikipedia as Resolved.
Reedy closed subtask T225414: File namespace added to FlaggedRevs common configuration as Resolved.
Reedy closed subtask T225276: FlaggedRevs (statistics) first three namespaces are listed twice as Resolved.
Udo_T reopened subtask T226410: In de.wiktionary admins (again!!) no longer can grant the right for "autoreview" (passiver Sichter) or "editor" (Sichter). as Open.Jun 24 2019, 11:35 PM
Vladis13 reopened subtask T226054: FlaggedRevs disabled for NS "Wikisource", "MediaWiki" and "File" but it still requiring reviews for transcludes as Open.Jun 25 2019, 8:05 PM
Aklapper closed subtask T226410: In de.wiktionary admins (again!!) no longer can grant the right for "autoreview" (passiver Sichter) or "editor" (Sichter). as Resolved.Jun 29 2019, 11:56 AM
Urbanecm added a subtask: T226932: Disabled auto promotion to `editor` on arwiki works again.Jun 30 2019, 12:20 PM
Urbanecm moved this task from Backlog to Analysis / under discussion on the Wikimedia-Site-requests board.Jul 1 2019, 2:48 PM
Ata added a subtask: T227260: Last reviewed revision is shown to logged-out users in ukwiki instead of last revision.Jul 4 2019, 8:48 AM
Udo_T mentioned this in T229327: autopromote of "autoreview" (passiver Sichter) no longer seems to work in de.wiktionary.Jul 30 2019, 1:09 PM
NickK mentioned this in T227260: Last reviewed revision is shown to logged-out users in ukwiki instead of last revision.Aug 24 2019, 12:09 PM
NickK subscribed.

@Reedy @Quiddity is there any progress on this? In Ukrainian Wikipedia T227260 was caused by this change and is not fixed for over two months now. Thanks

NickK awarded a token.Aug 24 2019, 12:11 PM
Reedy closed subtask T227260: Last reviewed revision is shown to logged-out users in ukwiki instead of last revision as Resolved.Sep 3 2019, 4:01 PM
NickK rescinded a token.Sep 3 2019, 4:49 PM
Ammarpad added a subtask: T229327: autopromote of "autoreview" (passiver Sichter) no longer seems to work in de.wiktionary.Nov 28 2019, 6:26 PM
Amorymeltzer subscribed.Feb 3 2020, 1:19 AM
• matmarex closed subtask T226932: Disabled auto promotion to `editor` on arwiki works again as Resolved.Sep 14 2020, 3:29 PM
• matmarex added a subtask: T237191: FlaggedRevs: Automatic user promotion stopped working on some wikis on June 24, 2019.Sep 14 2020, 3:32 PM
DannyS712 subscribed.Sep 14 2020, 5:00 PM
• matmarex closed subtask T237191: FlaggedRevs: Automatic user promotion stopped working on some wikis on June 24, 2019 as Resolved.Sep 18 2020, 10:24 PM
DonRumata added a subtask: T139246: Migrate local group names to WikimediaMessages.Feb 22 2021, 10:52 AM
DonRumata added a subtask: T275337: Rename "autoeditor" user group in ruwiki to "autoreview".
Zabe subscribed.Feb 25 2021, 1:25 PM
DonRumata removed a subtask: T275337: Rename "autoeditor" user group in ruwiki to "autoreview".Feb 27 2021, 9:18 PM
Ailbeve subscribed.Mar 30 2021, 8:18 PM
Ladsgroup closed subtask T226054: FlaggedRevs disabled for NS "Wikisource", "MediaWiki" and "File" but it still requiring reviews for transcludes as Resolved.Jan 13 2022, 5:41 AM
• matmarex closed this task as Resolved.Jan 13 2022, 7:28 PM
• matmarex removed a subtask: T139246: Migrate local group names to WikimediaMessages.

It looks like there are no other known issues related to this.

(I removed T139246 as subtask, since it doesn't seem to be about FlaggedRevs at all.)

Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy