The following methods in User are being replaced with UserGroupManager.
The goal of this task is to hard-deprecate the following methods:
- public function getGroups()
- public function addGroup()
- public function removeGroup()
- public function getGroupMemberships()
- public function getEffectiveGroups() => Done
- public function getAutomaticGroups() => Done
- public function getFormerGroups() => Done
- public function addAutopromoteOnceGroups() => Done
- public static function getAllGroups()
- public static function getImplicitGroups()
Steps:
- use https://codesearch.wmcloud.org/search/ tool to find all the usages of these methods in extensions. Make a list, WMF deployed extensions separately, not WMF deployed extensions separately (you can select Wikimedia deployed) in the tool
- All usages of deprecated methods in the deployed extensions need to be replaced with corresponding UserGroupManager methods. You can obtain UserGroupManager via MediaWikiServices::getInstance()->getUserGroupManager(), but it's preferred to inject it if possible.
- Patches for all extensions that are not deployed should be created, but there's no requirement for them to get merged.
WMF deployed
- extensions / Translate
- extensions / Wikibase
- extensions / CheckUser
- extensions / SecurePoll
- extensions / UserMerge
- extensions / WikibaseMediaInfo
- operations/mediawiki-config
- extensions / AbuseFilter
- extensions / EventBus
- extensions / LdapAuthentication
- extensions / OAuth
- extensions / Flow
- extensions / BetaFeatures
- extensions / CentralAuth
- extensions / GlobalCssJs
- extensions / CentralNotice
not WMF deployed
- extensions / LDAPGroups
- extensions / WikiLexicalData
- extensions / BlueSpiceFoundation
- extensions / SimpleSAMLphp
- extensions / AbsenteeLandlord
- extensions / AccessControl
- extensions / ApprovedRevs
- extensions / BatchUserRights
- extensions / BlueSpiceDashboards
- extensions / BlueSpiceFlaggedRevsConnector
- extensions / BlueSpicePageAccess
- extensions / BlueSpiceUserManager
- extensions / BlueSpiceSMWConnector
- extensions / ConfirmAccount
- extensions / Farmer
- extensions / ImportUsers
- extensions / LinkFilter
- extensions / RevisionCommentSupplement
- extensions / SocialProfile
- extensions / WikiToLDAP
- mediawiki / vagrant
- skins / Cosmos
- skins / Tweeki
- extensions / Auth_remoteuser
- extensions / GlobalNotice
- extensions / GroupsSidebar
- extensions / GroupWhitelist
- extensions / HAWelcome
- extensions / Lockdown
- extensions / LockDownEnglishPages
- extensions / PageForms
- extensions / PrivateDomains
- extensions / Quantcast
- extensions / RightFunctions
- extensions / SemanticACL
- extensions / SemanticPageSeries
- extensions / ShoutWikiAds
- extensions / ShoutWikiAPI
- extensions / StaffPowers
- extensions / UserFunctions
- extensions / WikiForum
- extensions / WSOAuth
- extensions / DisableAccount
- extensions / InviteSignup
- extensions / Shibboleth