-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: fix rmSync error code #57103
base: main
Are you sure you want to change the base?
fs: fix rmSync error code #57103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you please add a test
Update: There is already a test for this that is now failing. I will update the test. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57103 +/- ##
==========================================
- Coverage 89.09% 89.09% -0.01%
==========================================
Files 665 665
Lines 193249 193250 +1
Branches 37231 37232 +1
==========================================
- Hits 172175 172172 -3
- Misses 13802 13813 +11
+ Partials 7272 7265 -7
|
The behavior of The libcxx implementation ignores errors when deleting files that can not be deleted: I will make the required changes and check how the test runs under Windows. But first, I will ask the libcxx folks if this is expected behavior or if it also needs fixing. |
Return the correct error code, when a directory_not_empty error occurred. Fixes: nodejs#57095
Return the correct error code, when a directory_not_empty error occurred.
Fixes: #57095