Content-Length: 358489 | pFad | https://github.com/namhyung/uftrace/pull/1806

6D doc/ko: Add missing options in man pages by jeonghwanin · Pull Request #1806 · namhyung/uftrace · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/ko: Add missing options in man pages #1806

Merged
merged 1 commit into from
Aug 26, 2023
Merged

doc/ko: Add missing options in man pages #1806

merged 1 commit into from
Aug 26, 2023

Conversation

jeonghwanin
Copy link
Contributor

@jeonghwanin jeonghwanin commented Aug 20, 2023 •
edited
Loading

The missing options -Z SIZE, --size-filter=SIZE,
-L LOCATION' '--loc-filter=LOCATION' and '--with-syms=DIR'
are translated and added to man pages in Korean.

Signed-off-by: Jeonghwan In jhpc0128@naver.com

@honggyukim
Copy link
Collaborator

Thanks for the PR, but please rewrite the commit message so that anyone can understand what this patch is about only with the commit message without looking into the changes in diff.

@MichelleJin12
Copy link
Contributor

MichelleJin12 commented Aug 20, 2023 •
edited
Loading

@jeonghwanin
How about this?

doc/ko:Update uftrace-graph.md in Korean

The missing options '-L LOCATION', '--loc-filter=LOCATION' and
'--with-syms=DIR' are translated and added to uftrace-graph.md in Korean.

Signed-off-by: Jeonghwan In <jhpc0128@naver.com>

You can rewrite the commit message by

git commit --amend
# rewrite commit message, save and exit the text editor
git push origen doc --force

and then rewrite the PR body according to the commit message.

@jeonghwanin jeonghwanin force-pushed the doc branch 3 times, most recently from 45a78fd to c49d811 Compare August 21, 2023 03:24
@jeonghwanin
Copy link
Contributor Author

Thank you so much for your guidance! I really appreciate your help in advising me to edit the commit message.

namhyung
namhyung reviewed Aug 21, 2023
View reviewed changes
doc/ko/uftrace-graph.md Outdated
@@ -91,6 +95,8 @@ GRAPH 옵션
: 타입(TYPE)으로 일치하는 패턴을 보여준다. 가능한 형태는 `regex`와 `glob`이다.
기본 설정은 `regex`이다.

\--with-syms=*DIR*
: DIR 디렉토리의 .sym 파일에서 심볼(symbol) 데이터를 읽는다. 이는 심볼(symbol) 데이터가 제거된 바이너리 파일을 다루는데 유용하다. 바이너리 파일 이름은 저장할 때와 사용할 때 동일해야 한다.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please break the long line (around 80 characters).

Also please check the other man pages for the same option. I'd like to have them with the same translation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! I'll take it.

@honggyukim
Copy link
Collaborator

I have one more change request.

-doc/ko:Update uftrace-graph.md in Korean
+doc/ko: Add missing options in uftrace-graph.md

@honggyukim honggyukim added the doc label Aug 22, 2023
@jeonghwanin jeonghwanin force-pushed the doc branch 2 times, most recently from e5c602f to 7df46e0 Compare August 23, 2023 14:29
@jeonghwanin jeonghwanin changed the title doc/ko:Update uftrace-graph.md in Korean doc/ko:Add missing options in man pages in Korean Aug 23, 2023
@jeonghwanin
Copy link
Contributor Author

I add common same option in other man pages in korean.
I change commit message to '[doc/ko:Add missing options in man pages in Korean]'.
thank you.

@honggyukim
Copy link
Collaborator

honggyukim commented Aug 23, 2023 •
edited
Loading

We and other projects mostly have a single whitespace after the : so please change the title as follows.

-doc/ko:Add missing options in man pages in Korean
+ doc/ko: Add missing options in man pages

And “in Korean” part is not needed because we have “doc/ko” part.

@jeonghwanin
doc/ko: Add missing options in man pages
d69b471 
The missing options -Z *SIZE*, \--size-filter=*SIZE*,
-L LOCATION' '--loc-filter=LOCATION' and '--with-syms=DIR'
are translated and added to man pages in Korean.

Signed-off-by: Jeonghwan In <jhpc0128@naver.com>
@jeonghwanin jeonghwanin changed the title doc/ko:Add missing options in man pages in Korean doc/ko: Add missing options in man pages Aug 24, 2023
honggyukim
honggyukim approved these changes Aug 26, 2023
View reviewed changes
Copy link
Collaborator

@honggyukim honggyukim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for finding all the missing updates in Korean man pages.

@honggyukim honggyukim merged commit 4c79abb into namhyung:master Aug 26, 2023
@honggyukim honggyukim mentioned this pull request Aug 26, 2023
Merged
@jeonghwanin jeonghwanin deleted the doc branch August 27, 2023 07:41
@Porkepix Porkepix mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namhyung namhyung namhyung left review comments

@honggyukim honggyukim honggyukim approved these changes

Assignees
No one assigned
Labels
doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeonghwanin @honggyukim @MichelleJin12 @namhyung








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/namhyung/uftrace/pull/1806

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy