fix: move IMessageProducer and IProducerAccessor from main project to Abstractions #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please suggest a fix for Its not used in the interface, but its used in the base interface it inherits/extends. |
BLage
reviewed
Apr 22, 2025
…from Confluent.Kafka This moves IMessageProducer.cs and IProducerAccessor.cs into the Abstractions project, introduces delivery-report and result-flow conversions for KafkaFlow, and fully decouples KafkaFlow from Confluent.Kafka
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ect to Abstractions by introducing delivery report flow and result flow conversions for KafkaFlow and decoupling it from Confluent.Kafka.
Description
Move IMessageProducer.cs and IProducerAccessor.cs from main project to Abstractions by introducing delivery report flow and result flow conversions for KafkaFlow and decoupling it from Confluent.Kafka.
I created 3 interfaces and 3 implementations (as a transfer object) mirroring the original, replacing types with
objectfor those for which implementing the types would be a little too much work, and since a lot of the project already just usesobject, I followed suit. The only purpose of this PR is to move the interfaces to the Abstractions project as they are too coupled and prevents the Abstrations project to be what it should be.Fixes # (issue)
Decouples IProducerAccessor and IMessageProducer from Confluent.Kafka's
DeliveryResultandDeliveryReportand moves the Interfaces to the ideal place: the Abstractions project.How Has This Been Tested?
Imported my local KafkaFlow to both a producing and consumer project and it ran without throwing an exception.
An extra manual check would be appreciated.
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement