Skip to content

fix(docs-infra): update docs-alert and fix tests #60827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix(docs-infra): update docs-alert and fix tests #60827

wants to merge 2 commits into from

Conversation

alan-agius4
Copy link
Contributor

Before this commit, the docs-alert tests were failing. This also ensures that NOTE: is always capitalized.

 ~/git/angular   docs-alert  yarn bazel test //adev/shared-docs/pipeline/guides/testing:unit_tests
yarn run v1.22.22
$ /usr/local/google/home/alanagius/git/angular/node_modules/.bin/bazel test //adev/shared-docs/pipeline/guides/testing:unit_tests
INFO: Analyzed target //adev/shared-docs/pipeline/guides/testing:unit_tests (408 packages loaded, 17245 targets configured).
INFO: Found 1 test target...
Target //adev/shared-docs/pipeline/guides/testing:unit_tests up-to-date:
  dist/bin/adev/shared-docs/pipeline/guides/testing/unit_tests.sh
  dist/bin/adev/shared-docs/pipeline/guides/testing/unit_tests_require_patch.cjs
INFO: Elapsed time: 14.485s, Critical Path: 0.02s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
//adev/shared-docs/pipeline/guides/testing:unit_tests           (cached) PASSED in 2.6s

Executed 0 out of 1 test: 1 test passes.
INFO: Build completed successfully, 1 total action
Done in 14.63s.

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Apr 10, 2025
@alan-agius4 alan-agius4 requested a review from devversion April 10, 2025 12:46
@angular-robot angular-robot bot added the area: docs-infra Angular.dev application and infrastructure label Apr 10, 2025
@ngbot ngbot bot added this to the Backlog milestone Apr 10, 2025
@alan-agius4 alan-agius4 removed the request for review from devversion April 10, 2025 12:49
@alan-agius4 alan-agius4 changed the title fix(docs-infra): update docs-alert and re-enable tests fix(docs-infra): update docs-alert and fix tests Apr 10, 2025
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Apr 10, 2025
@alan-agius4 alan-agius4 mentioned this pull request Apr 10, 2025
Closed
@alan-agius4
fix(docs-infra): update docs-alert and re-enable tests
60fdbb8 
Before this commit, the docs-alert tests were failing. This also ensures that `NOTE:` is always capitalized.
@alan-agius4
fixup! fix(docs-infra): update docs-alert and re-enable tests
8cecfba
@kirjs
Copy link
Contributor

kirjs commented Apr 10, 2025

This PR was merged into the repository by commit 654e6da.

The changes were merged into the following branches: main

@kirjs kirjs closed this in 654e6da Apr 10, 2025
@alan-agius4 alan-agius4 deleted the docs-alert branch April 10, 2025 15:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs-infra Angular.dev application and infrastructure target: major This PR is targeted for the next major release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@alan-agius4 @kirjs @JeanMeche
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy