fix(core): avoid injecting internal error handler from a destroyed injector #62275
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturovt
commented
Jun 25, 2025
| @@ -699,7 +699,8 @@ export function handleUncaughtError(lView: LView, error: any): void { | |||
| if (!injector) { | |||
| return; | |||
| } | |||
| const errorHandler = injector.get(INTERNAL_APPLICATION_ERROR_HANDLER, null); | |||
| // TODO(atscott): should we re-throw an error in a `setTimeout` if injector is destroyed? | |||
…jector
This commit prevents lazy injection of the internal `ErrorHandler` from a destroyed injector, which would otherwise result in a secondary "destroyed injector" error.
The `handleUncaughtError` function is used in a wrapped event listener that invokes the `ErrorHandler` if the listener throws. A simple case in a micro-frontend application:
```ts
onNavigationToAnotherApp() {
this.appRef.destroy();
do_some_stuff_ie_loggin_that_may_throw();
}
```
If the function throws an error, Angular attempts to inject the `ErrorHandler` from a destroyed injector.
13c53f1 to
4c49e1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit prevents lazy injection of the internal
ErrorHandlerfrom a destroyed injector, which would otherwise result in a secondary "destroyed injector" error.The
handleUncaughtErrorfunction is used in a wrapped event listener that invokes theErrorHandlerif the listener throws. A simple case in a micro-frontend application:If the function throws an error, Angular attempts to inject the
ErrorHandlerfrom a destroyed injector.