-
Notifications
You must be signed in to change notification settings - Fork 979
Fix panic on lossy decimal to float casting: round to saturation for overflows #7887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
cb41f13
Enhance decimal casting functions to return errors on conversion fail…
kosiew 89d360e
Enhance documentation for `cast_decimal_to_float` function to clarify…
kosiew cf9268d
Enhance error handling in `cast_decimal_to_float` function to include…
kosiew 8ca4168
Revert "Enhance error handling in `cast_decimal_to_float` function to…
kosiew 1bbfae3
made the code uniform by using the .map() pattern for both Float32 an…
kosiew c658501
Add test for casting Decimal128 to Float64 with overflow handling
kosiew 8e74ff2
Add tests for overflow handling when casting Decimal128 and Decimal25…
kosiew 3217813
Revert "Enhance decimal casting functions to return errors on convers…
kosiew ea83122
fix(decimal cast): convert decimal to float with saturation instead o…
kosiew 05ace0c
test(decimal cast): add tests for positive and negative overflow when…
kosiew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
test(decimal cast): add tests for positive and negative overflow when…
… casting Decimal256 to Float64
- Loading branch information
commit 05ace0c53dea226d38ab6cd5eb8b923a2725f65a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to cover negative infinity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@klion26
Good catch.
I amended the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also please either add or ensure there is an existing test for casting
Decimal128
(i128::MIN
andi128::MAX
tof64
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update, I didn't notice that @kosiew added a follow on ticket to track this work:
Decimal128
(i128::MIN
andi128::MAX
) tof64
with overflow handling #7939