Skip to content

Fix panic on lossy decimal to float casting: round to saturation for overflows #7887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 23, 2025
Merged

Fix panic on lossy decimal to float casting: round to saturation for overflows #7887

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cb41f13
Enhance decimal casting functions to return errors on conversion fail…
kosiew Jul 9, 2025
89d360e
Enhance documentation for `cast_decimal_to_float` function to clarify…
kosiew Jul 9, 2025
cf9268d
Enhance error handling in `cast_decimal_to_float` function to include…
kosiew Jul 9, 2025
8ca4168
Revert "Enhance error handling in `cast_decimal_to_float` function to…
kosiew Jul 9, 2025
1bbfae3
made the code uniform by using the .map() pattern for both Float32 an…
kosiew Jul 9, 2025
c658501
Add test for casting Decimal128 to Float64 with overflow handling
kosiew Jul 9, 2025
8e74ff2
Add tests for overflow handling when casting Decimal128 and Decimal25…
kosiew Jul 9, 2025
3217813
Revert "Enhance decimal casting functions to return errors on convers…
kosiew Jul 9, 2025
ea83122
fix(decimal cast): convert decimal to float with saturation instead o…
kosiew Jul 9, 2025
05ace0c
test(decimal cast): add tests for positive and negative overflow when…
kosiew Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
made the code uniform by using the .map() pattern for both Float32 an… 
…d Float64 conversions
  • Loading branch information
@kosiew
kosiew committed Jul 9, 2025
commit 1bbfae3ee09facd1338002f37e66ddf9551cd0a9
2 changes: 1 addition & 1 deletion arrow-cast/src/cast/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1982,7 +1982,7 @@ where
Int32 => cast_decimal_to_integer::<D, Int32Type>(array, base, *scale, cast_options),
Int64 => cast_decimal_to_integer::<D, Int64Type>(array, base, *scale, cast_options),
Float32 => cast_decimal_to_float::<D, Float32Type, _>(array, |x| {
Ok((as_float(x)? / 10_f64.powi(*scale as i32)) as f32)
as_float(x).map(|v| (v / 10_f64.powi(*scale as i32)) as f32)
}),
Float64 => cast_decimal_to_float::<D, Float64Type, _>(array, |x| {
as_float(x).map(|v| v / 10_f64.powi(*scale as i32))
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy