Skip to content

fix: parent relative paths, and rework on the whole path extraction mechanics #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 30, 2025
Merged

fix: parent relative paths, and rework on the whole path extraction mechanics #429

merged 7 commits into from
May 30, 2025

Conversation

Tal500
Copy link
Contributor

@Tal500 Tal500 commented May 21, 2025 •
edited
Loading

  • Include also another integration test function to check header in parent dir usage (that was failing in previous commit).
  • Add a safety check that we did not meet the header file that we are about to insert to the map (abort with stderr message otherwise) - this not only detect unmet bugs in including paths, but also avoid memory leak.
  • Add much more cover in the test functions, and check more details.

Tal500 added 3 commits May 21, 2025 13:06
@Tal500
fix: parent relative paths, and rework on the whole path extraction m…
903cf7f 
…echanics

Include also another integration test function to check header in parent dir usage (was failing before)
@Tal500
fixes
89377e6
@Tal500
more fixes
4d4bab8
@Tal500 Tal500 force-pushed the fix-parent-relative-path branch from 48cff47 to 4d4bab8 Compare May 21, 2025 12:01
@Tal500 Tal500 marked this pull request as draft May 21, 2025 16:43
danmar
danmar reviewed May 22, 2025
View reviewed changes
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments. I didn't check it all carefully yet.

@Tal500 Tal500 marked this pull request as ready for review May 22, 2025 10:24
@Tal500 Tal500 mentioned this pull request May 22, 2025
Closed
danmar
danmar reviewed May 23, 2025
View reviewed changes
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small question. partial review.

@danmar danmar mentioned this pull request May 30, 2025
Merged
danmar
danmar reviewed May 30, 2025
View reviewed changes
@Tal500
Copy link
Contributor Author

Tal500 commented May 30, 2025

I read your comments and reply in the code context.
I do think that even if you want to have a fine graded internal testing, you shall first merge this PR and introduce in a new PR the new extra internal unitest system.

@danmar danmar merged commit 76df97f into danmar:master May 30, 2025
16 checks passed
@Tal500 Tal500 deleted the fix-parent-relative-path branch June 12, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmar danmar danmar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tal500 @danmar
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy