fix(voice): dont set initial transitions as pending

discordjs · kodiakhq · Jul 13, 2025 · Jun 4, 2025 · Jun 4, 2025 · Jun 4, 2025
commit d44b76aa3d76717184ce8439e5f77ed01f8328dc
@@ -219,7 +219,8 @@ export class DAVESession extends EventEmitter {
 		const transitionId = payload.readUInt16BE(0);
 		try {
 			this.session.processCommit(payload.subarray(2));
-			this.pendingTransition = { transition_id: transitionId, protocol_version: this.protocolVersion };
+			if (transitionId !== 0)
+				this.pendingTransition = { transition_id: transitionId, protocol_version: this.protocolVersion };
 			this.emit('debug', `MLS commit processed (transition id: ${transitionId})`);
 			return { transitionId, success: true };
 		} catch (error) {
@@ -238,7 +239,8 @@ export class DAVESession extends EventEmitter {
 		const transitionId = payload.readUInt16BE(0);
 		try {
 			this.session.processWelcome(payload.subarray(2));
-			this.pendingTransition = { transition_id: transitionId, protocol_version: this.protocolVersion };
+			if (transitionId !== 0)
+				this.pendingTransition = { transition_id: transitionId, protocol_version: this.protocolVersion };
 			this.emit('debug', `MLS welcome processed (transition id: ${transitionId})`);
 			return { transitionId, success: true };
 		} catch (error) {

@@ -555,17 +555,19 @@ export class Networking extends EventEmitter {
 				if (payload) this.state.ws.sendBinaryMessage(VoiceOpcodes.DaveMlsCommitWelcome, payload);
 			} else if (message.op === VoiceOpcodes.DaveMlsAnnounceCommitTransition) {
 				const { transitionId, success } = this.state.dave.processCommit(message.payload);
-				this.state.ws.sendPacket({
-					op: success ? VoiceOpcodes.DaveTransitionReady : VoiceOpcodes.DaveMlsInvalidCommitWelcome,
-					d: { transition_id: transitionId },
-				});
+				if (transitionId !== 0)
+					this.state.ws.sendPacket({
+						op: success ? VoiceOpcodes.DaveTransitionReady : VoiceOpcodes.DaveMlsInvalidCommitWelcome,
+						d: { transition_id: transitionId },
+					});
 				if (!success) this.state.dave.reinit();
 			} else if (message.op === VoiceOpcodes.DaveMlsWelcome) {
 				const { transitionId, success } = this.state.dave.processWelcome(message.payload);
-				this.state.ws.sendPacket({
-					op: success ? VoiceOpcodes.DaveTransitionReady : VoiceOpcodes.DaveMlsInvalidCommitWelcome,
-					d: { transition_id: transitionId },
-				});
+				if (transitionId !== 0)
+					this.state.ws.sendPacket({
+						op: success ? VoiceOpcodes.DaveTransitionReady : VoiceOpcodes.DaveMlsInvalidCommitWelcome,
+						d: { transition_id: transitionId },
+					});
 				if (!success) this.state.dave.reinit();
 			}
 		}