fix(voice): actually send a transition ready when ready

discordjs · kodiakhq · Jul 13, 2025 · Jun 4, 2025 · Jun 4, 2025 · Jun 4, 2025
commit f8fa827fe1d121560b2c3c6ec1eb90366fbac900
@@ -13,9 +13,9 @@ const TRANSITION_EXPIRY = 10;
 
 /**
  * The arbitrary amount of seconds to allow passthrough for mid-downgrade.
- * Generally, transitions should not even last this long, but should be more than enough to cover it.
+ * Generally, transitions last about 3 seconds maximum, but this should cover for when connections are delayed.
  */
-const TRANSITION_EXPIRY_PENDING_DOWNGRADE = 120;
+const TRANSITION_EXPIRY_PENDING_DOWNGRADE = 24;
 
 /**
  * The amount of packets to allow decryption failure for until we deem the transition bad and re-initialize.

@@ -537,8 +537,14 @@ export class Networking extends EventEmitter {
 			(this.state.code === NetworkingStatusCode.Ready || this.state.code === NetworkingStatusCode.Resuming) &&
 			this.state.dave
 		) {
-			if (packet.op === VoiceOpcodes.DavePrepareTransition) this.state.dave.prepareTransition(packet.d);
-			else if (packet.op === VoiceOpcodes.DaveExecuteTransition)
+			if (packet.op === VoiceOpcodes.DavePrepareTransition) {
+				const ready = this.state.dave.prepareTransition(packet.d);
+				if (ready)
+					this.state.ws.sendPacket({
+						op: VoiceOpcodes.DaveTransitionReady,
+						d: { transition_id: packet.d.transition_id },
+					});
+			} else if (packet.op === VoiceOpcodes.DaveExecuteTransition)
 				this.state.dave.executeTransition(packet.d.transition_id);
 			else if (packet.op === VoiceOpcodes.DavePrepareEpoch) this.state.dave.prepareEpoch(packet.d);
 		}