Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic IDP support #2405

Merged
merged 8 commits into from
Feb 23, 2019
Merged

Generic IDP support #2405

merged 8 commits into from
Feb 23, 2019

Conversation

Yue-Wang-Google
Copy link
Contributor

No description provided.

@Yue-Wang-Google Yue-Wang-Google force-pushed the headful-lite branch 8 times, most recently from e47433e to 307eaff Compare February 20, 2019 20:22
@Yue-Wang-Google
Copy link
Contributor Author

Hi @paulb777 we're going to release this in M44. Do you know what might be causing the travis error below?

I didn't change the podspec at all.

 -> FirebaseAuth (5.3.0)
    - ERROR | [iOS] unknown: Encountered an unknown error (409: unexpected token at '{
        "availability" : "(available)",
        "state" : "Shutdown",
        "isAvailable" : true,
        "name" : "iPhone 5s",
') during validation.
[!] FirebaseAuth did not pass validation, due to 1 error.
You can use the `--no-clean` option to inspect any issue.
The command "./scripts/if_changed.sh ./scripts/pod_lib_lint.sh FirebaseAuth.podspec" failed. Retrying, 3 of 3.

@paulb777
Copy link
Member

The paste you show above is a network flake, but there are real issues ...

Running locally in the branch shows the issues below. You should be able to debug in an Xcode workspace if you add the -no-clean option.

Let me know if you're still stuck after that.

pod lib lint FirebaseAuth.podspec

 -> FirebaseAuth (5.3.0)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Planning build
    - NOTE  | xcodebuild:  note: Constructing build description
    - NOTE  | xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file. (in target 'App')
    - ERROR | xcodebuild: Returned an unsuccessful exit code. You can use `--verbose` for more information.
    - NOTE  | xcodebuild:  /Users/paulbeusterien/github/firebase-ios-sdk/Firebase/Auth/Source/AuthProviders/OAuth/FIROAuthProvider.m:26:9: fatal error: 'FIRAuthURLPresenter.h' file not found
    - WARN  | xcodebuild:  /Users/paulbeusterien/github/firebase-ios-sdk/Firebase/Auth/Source/FIRAuth.m:256:17: warning: method definition for 'signInWithProvider:UIDelegate:completion:' not found [-Wincomplete-implementation]
    - NOTE  | xcodebuild:  /Users/paulbeusterien/github/firebase-ios-sdk/Firebase/Auth/Source/Public/FIRAuth.h:513:1: note: method 'signInWithProvider:UIDelegate:completion:' declared here
    - WARN  | [tvOS] xcodebuild:  /Users/paulbeusterien/github/firebase-ios-sdk/Firebase/Auth/Source/FIRAuthWebUtils.m:168:24: warning: 'stringByReplacingPercentEscapesUsingEncoding:' is deprecated: first deprecated in tvOS 9.0 - Use -stringByRemovingPercentEncoding instead, which always uses the recommended UTF-8 encoding. [-Wdeprecated-declarations]
    - NOTE  | [tvOS] xcodebuild:  /Users/paulbeusterien/Downloads/Xcode-beta.app/Contents/Developer/Platforms/AppleTVSimulator.platform/Developer/SDKs/AppleTVSimulator12.2.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURL.h:593:1: note: 'stringByReplacingPercentEscapesUsingEncoding:' has been explicitly marked deprecated here

[!] FirebaseAuth did not pass validation, due to 1 error and 2 warnings.
You can use the `--no-clean` option to inspect any issue.

renkelvin
renkelvin approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@renkelvin renkelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code already reviewed in the private repo. Ready to merge once the build issue is fixed.

paulb777
paulb777 approved these changes Feb 23, 2019
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the fix for the travis failure is from a regression today for which the fix was just pushed to master.

@Yue-Wang-Google
Copy link
Contributor Author

All tests passed! Submitting.

@Yue-Wang-Google Yue-Wang-Google merged commit 2e77efd into master Feb 23, 2019
@paulb777 paulb777 added this to the M44 milestone Feb 23, 2019
@mono0926 mono0926 mentioned this pull request Mar 12, 2019
Closed
@Yue-Wang-Google Yue-Wang-Google deleted the headful-lite branch March 12, 2019 21:41
@ryanwilson ryanwilson mentioned this pull request Apr 3, 2019
Merged
@firebase firebase locked and limited conversation to collaborators Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@renkelvin renkelvin renkelvin approved these changes

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: auth cla: yes
Projects
None yet
Milestone
5.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Yue-Wang-Google @paulb777 @renkelvin @googlebot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy