Wrap ShutdownHook calls to avoid crashing the tool
#171917
Open
+56
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonyi
approved these changes
Jul 10, 2025
| for (final ShutdownHook shutdownHook in registeredHooks) { | ||
| try { | ||
| final Future<void> future = asyncGuard<void>( | ||
| () async => shutdownHook(), |
There was a problem hiding this comment.
Can this just be shutdownHook since ShutdownHook is just FutureOr<void> Function()?
There was a problem hiding this comment.
No, because asyncGuard requires Future<T> and shutdownHook is FutureOr<>.
|
autosubmit label was removed for flutter/flutter/171917, because - The status or check suite Linux analyzer_benchmark has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
autosubmit label was removed for flutter/flutter/171917, because - The status or check suite Linux tool_integration_tests_1_7 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57351.