Wrap ShutdownHook calls to avoid crashing the tool
#171917
Conversation
| for (final ShutdownHook shutdownHook in registeredHooks) { | ||
| try { | ||
| final Future<void> future = asyncGuard<void>( | ||
| () async => shutdownHook(), |
There was a problem hiding this comment.
Can this just be shutdownHook since ShutdownHook is just FutureOr<void> Function()?
There was a problem hiding this comment.
No, because asyncGuard requires Future<T> and shutdownHook is FutureOr<>.
|
autosubmit label was removed for flutter/flutter/171917, because - The status or check suite Linux analyzer_benchmark has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
autosubmit label was removed for flutter/flutter/171917, because - The status or check suite Linux tool_integration_tests_1_7 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
autosubmit label was removed for flutter/flutter/171917, because Pull request flutter/flutter/171917 is not in a mergeable state. |
|
autosubmit label was removed for flutter/flutter/171917, because - The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
Closes #57351.