Skip to content

[video_player] Add html 5 video poster support (thumbnail) as a VideoPlayerWebOptions #8940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 9, 2025
Merged

[video_player] Add html 5 video poster support (thumbnail) as a VideoPlayerWebOptions #8940

merged 11 commits into from
Jul 9, 2025
+81 −3

Conversation

Ortes
Copy link
Contributor

@Ortes Ortes commented Mar 31, 2025 •
edited by stuartmorgan-g
Loading

This PR adds support for the poster attribute on web by introducing a poster field in VideoPlayerWebOptions. It allows setting a thumbnail image for videos using the native HTML5 poster property, improving the out-of-the-box web experience.

Fixes flutter/flutter#166232

Pre-Review Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I linked to at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under1.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3

@Ortes Ortes requested review from ditman and tarrinneal as code owners March 31, 2025 01:12
@Ortes Ortes mentioned this pull request Mar 31, 2025
Open
@Ortes Ortes force-pushed the video-player-html-poster-support branch from 713c652 to d529939 Compare March 31, 2025 22:43
@Ortes Ortes force-pushed the video-player-html-poster-support branch from d529939 to b43bf65 Compare April 1, 2025 18:03
@Ortes Ortes force-pushed the video-player-html-poster-support branch 2 times, most recently from 2b124fe to 71ea426 Compare April 1, 2025 18:37
@Ortes Ortes changed the title [video_player] Add html 5 video poster support (thumbnail) as a VideoPlayerWebOptions [video_player_platform_interface] Add html 5 video poster support (thumbnail) as a VideoPlayerWebOptions Apr 1, 2025
@Ortes Ortes mentioned this pull request Apr 1, 2025
Closed
11 tasks
@stuartmorgan-g stuartmorgan-g added the triage-web Should be looked at in web triage label Apr 1, 2025
@stuartmorgan-g
Copy link
Contributor

Where is the combination PR for initial review that this was split from (per the documented process)?

@Ortes Ortes force-pushed the video-player-html-poster-support branch from c3d02e8 to eb0d4b7 Compare April 1, 2025 20:20
@Ortes Ortes mentioned this pull request Apr 1, 2025
Merged
11 tasks
@Ortes Ortes changed the title [video_player_platform_interface] Add html 5 video poster support (thumbnail) as a VideoPlayerWebOptions [video_player] Add html 5 video poster support (thumbnail) as a VideoPlayerWebOptions Apr 1, 2025
@stuartmorgan-g
Copy link
Contributor

It looks like this never got a test at the web implementation package level, which was missed during review.

packages/packages/video_player/video_player_web/example/integration_test/video_player_test.dart

Line 412 in ca9b946

group('allowRemotePlayback', () {
is an example of a test similar to what we should have for this.

@Ortes
Copy link
Contributor Author

Ortes commented Jul 5, 2025

It looks like this never got a test at the web implementation package level, which was missed during review.

packages/packages/video_player/video_player_web/example/integration_test/video_player_test.dart

Line 412 in ca9b946

group('allowRemotePlayback', () {

is an example of a test similar to what we should have for this.

I added tests, they are AI generated but looks good to me and they pass of course. I hope that will do it

stuartmorgan-g
stuartmorgan-g requested changes Jul 5, 2025
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to use AI as part of your development process, but you are responsible for ensuring the quality of the code you submit for review regardless of how it was initially created.

stuartmorgan-g
stuartmorgan-g approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 9, 2025
@auto-submit auto-submit bot merged commit be35a18 into flutter:main Jul 9, 2025
78 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 17, 2025
@engine-flutter-autoroll
be35a186e [video_player] Add html 5 video poster support (thumbnail) …
3964a26 
…as a VideoPlayerWebOptions (flutter/packages#8940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 17, 2025
@engine-flutter-autoroll
be35a186e [video_player] Add html 5 video poster support (thumbnail) …
314fa7e 
…as a VideoPlayerWebOptions (flutter/packages#8940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 17, 2025
@engine-flutter-autoroll
be35a186e [video_player] Add html 5 video poster support (thumbnail) …
5e64719 
…as a VideoPlayerWebOptions (flutter/packages#8940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 17, 2025
@engine-flutter-autoroll
be35a186e [video_player] Add html 5 video poster support (thumbnail) …
a5f2b91 
…as a VideoPlayerWebOptions (flutter/packages#8940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 17, 2025
@engine-flutter-autoroll
be35a186e [video_player] Add html 5 video poster support (thumbnail) …
2ae5b47 
…as a VideoPlayerWebOptions (flutter/packages#8940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2025
Merged
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jul 17, 2025
@engine-flutter-autoroll
Roll Packages from 4a231ae8546d to cb8fef62993f (31 revisions) (#172303)
ae0700d 
flutter/packages@4a231ae...cb8fef6

2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.activity:activity from 1.9.3 to 1.10.1 in
/packages/image_picker/image_picker_android/android
(flutter/packages#8725)
2025-07-17 stuartmorgan@google.com [webview_flutter] Update
androidx.webkit to 1.14.0 (flutter/packages#9638)
2025-07-17 engine-flutter-autoroll@skia.org Roll Flutter from
c2739f0 to 9c626d9 (18 revisions) (flutter/packages#9641)
2025-07-17 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
077b4a4 to d7b523b (3 revisions) (flutter/packages#9640)
2025-07-17 stuartmorgan@google.com Fix Gemini note wrapping
(flutter/packages#9639)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.google.android.gms:play-services-maps from 18.2.0
to 19.2.0 in
/packages/google_maps_flutter/google_maps_flutter_android/android
(flutter/packages#9120)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.fragment:fragment from 1.6.2 to 1.8.8 in
/packages/local_auth/local_auth_android/android (flutter/packages#9406)
2025-07-16 stuartmorgan@google.com [ci] Add Gemini Code Assist review
config (flutter/packages#9632)
2025-07-16 engine-flutter-autoroll@skia.org Roll Flutter from
cc3110c to c2739f0 (15 revisions) (flutter/packages#9633)
2025-07-16 105786499+syedaniq@users.noreply.github.com [image_picker]
redesign example app (flutter/packages#9625)
2025-07-16 robert.odrowaz@leancode.pl [camera_avfoundation]
Implementation swift migration - part 7 (flutter/packages#9595)
2025-07-15 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_wkwebview] Replace Flutter method failure assertion
with nslog (flutter/packages#9587)
2025-07-15 engine-flutter-autoroll@skia.org Roll Flutter from
a930ec1 to cc3110c (24 revisions) (flutter/packages#9631)
2025-07-15 stuartmorgan@google.com [webview_flutter] Add
setMixedContentMode for Android (flutter/packages#9586)
2025-07-15 stuartmorgan@google.com [google_sign_in] Add exception info
to migration guide (flutter/packages#9574)
2025-07-14 392199+kwikwag@users.noreply.github.com [camera_android] Use
WeakReference to prevent startImageStream OOM error when main thread
hangs (#166533) (flutter/packages#9571)
2025-07-14 jason-simmons@users.noreply.github.com [quick_actions]
Restore the appShortcutLaunchActivityAfterStarting test in
quick_actions_android (flutter/packages#9508)
2025-07-14 engine-flutter-autoroll@skia.org Roll Flutter from
35f197f to a930ec1 (3 revisions) (flutter/packages#9624)
2025-07-14 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.9.1 to 8.11.1
in /packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#9618)
2025-07-12 engine-flutter-autoroll@skia.org Roll Flutter from
43657f3 to 35f197f (39 revisions) (flutter/packages#9602)
2025-07-11 stuartmorgan@google.com Replace popularity badges
(flutter/packages#9594)
2025-07-11 1961493+harryterkelsen@users.noreply.github.com [rfw] Update
test to not depend on toString() (flutter/packages#9590)
2025-07-11 robert.odrowaz@leancode.pl [camera_avfoundation]
Implementation swift migration - part 6 (flutter/packages#9588)
2025-07-10 52160996+FMorschel@users.noreply.github.com [url_launcher]
Fixes new unnecessary boolean operations warnings
(flutter/packages#9409)
2025-07-10 stuartmorgan@google.com [google_sign_in] Add troubleshooting
to Android README (flutter/packages#9581)
2025-07-10 engine-flutter-autoroll@skia.org Roll Flutter from
ac12f66 to 43657f3 (25 revisions) (flutter/packages#9589)
2025-07-10 32538273+ValentinVignal@users.noreply.github.com
[go_router_builder] Update case sensitive test to `go_router` 16.0.0
(flutter/packages#9482)
2025-07-09 737941+loic-sharma@users.noreply.github.com [rfw] Remove the
RFW WASM example (flutter/packages#9551)
2025-07-09 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
fcf2c11 to 077b4a4 (5 revisions) (flutter/packages#9585)
2025-07-09 engine-flutter-autoroll@skia.org Roll Flutter from
adffe24 to ac12f66 (28 revisions) (flutter/packages#9584)
2025-07-09 malo.allee@gmail.com [video_player] Add html 5 video poster
support (thumbnail) as a VideoPlayerWebOptions (flutter/packages#8940)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ash2moon ash2moon ash2moon left review comments

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@mdebbar mdebbar mdebbar approved these changes

@tarrinneal tarrinneal tarrinneal approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App federated: all_changes PR that contains changes for all packages for a federated plugin change p: video_player platform-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support poster attribute from the html video tag to get the thumbnail working on web
5 participants
@Ortes @stuartmorgan-g @mdebbar @tarrinneal @ash2moon
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy