[webview_flutter_wkwebview] Replace Flutter method failure assertion with nslog #9587
+32
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 17, 2025
…assertion with nslog (flutter/packages#9587)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 17, 2025
…assertion with nslog (flutter/packages#9587)
This was referenced Jul 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 17, 2025
…assertion with nslog (flutter/packages#9587)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 17, 2025
…assertion with nslog (flutter/packages#9587)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 17, 2025
…assertion with nslog (flutter/packages#9587)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 17, 2025
flutter/packages@4a231ae...cb8fef6 2025-07-17 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.activity:activity from 1.9.3 to 1.10.1 in /packages/image_picker/image_picker_android/android (flutter/packages#8725) 2025-07-17 stuartmorgan@google.com [webview_flutter] Update androidx.webkit to 1.14.0 (flutter/packages#9638) 2025-07-17 engine-flutter-autoroll@skia.org Roll Flutter from c2739f0 to 9c626d9 (18 revisions) (flutter/packages#9641) 2025-07-17 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 077b4a4 to d7b523b (3 revisions) (flutter/packages#9640) 2025-07-17 stuartmorgan@google.com Fix Gemini note wrapping (flutter/packages#9639) 2025-07-17 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.google.android.gms:play-services-maps from 18.2.0 to 19.2.0 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/packages#9120) 2025-07-17 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.fragment:fragment from 1.6.2 to 1.8.8 in /packages/local_auth/local_auth_android/android (flutter/packages#9406) 2025-07-16 stuartmorgan@google.com [ci] Add Gemini Code Assist review config (flutter/packages#9632) 2025-07-16 engine-flutter-autoroll@skia.org Roll Flutter from cc3110c to c2739f0 (15 revisions) (flutter/packages#9633) 2025-07-16 105786499+syedaniq@users.noreply.github.com [image_picker] redesign example app (flutter/packages#9625) 2025-07-16 robert.odrowaz@leancode.pl [camera_avfoundation] Implementation swift migration - part 7 (flutter/packages#9595) 2025-07-15 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Replace Flutter method failure assertion with nslog (flutter/packages#9587) 2025-07-15 engine-flutter-autoroll@skia.org Roll Flutter from a930ec1 to cc3110c (24 revisions) (flutter/packages#9631) 2025-07-15 stuartmorgan@google.com [webview_flutter] Add setMixedContentMode for Android (flutter/packages#9586) 2025-07-15 stuartmorgan@google.com [google_sign_in] Add exception info to migration guide (flutter/packages#9574) 2025-07-14 392199+kwikwag@users.noreply.github.com [camera_android] Use WeakReference to prevent startImageStream OOM error when main thread hangs (#166533) (flutter/packages#9571) 2025-07-14 jason-simmons@users.noreply.github.com [quick_actions] Restore the appShortcutLaunchActivityAfterStarting test in quick_actions_android (flutter/packages#9508) 2025-07-14 engine-flutter-autoroll@skia.org Roll Flutter from 35f197f to a930ec1 (3 revisions) (flutter/packages#9624) 2025-07-14 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.9.1 to 8.11.1 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#9618) 2025-07-12 engine-flutter-autoroll@skia.org Roll Flutter from 43657f3 to 35f197f (39 revisions) (flutter/packages#9602) 2025-07-11 stuartmorgan@google.com Replace popularity badges (flutter/packages#9594) 2025-07-11 1961493+harryterkelsen@users.noreply.github.com [rfw] Update test to not depend on toString() (flutter/packages#9590) 2025-07-11 robert.odrowaz@leancode.pl [camera_avfoundation] Implementation swift migration - part 6 (flutter/packages#9588) 2025-07-10 52160996+FMorschel@users.noreply.github.com [url_launcher] Fixes new unnecessary boolean operations warnings (flutter/packages#9409) 2025-07-10 stuartmorgan@google.com [google_sign_in] Add troubleshooting to Android README (flutter/packages#9581) 2025-07-10 engine-flutter-autoroll@skia.org Roll Flutter from ac12f66 to 43657f3 (25 revisions) (flutter/packages#9589) 2025-07-10 32538273+ValentinVignal@users.noreply.github.com [go_router_builder] Update case sensitive test to `go_router` 16.0.0 (flutter/packages#9482) 2025-07-09 737941+loic-sharma@users.noreply.github.com [rfw] Remove the RFW WASM example (flutter/packages#9551) 2025-07-09 engine-flutter-autoroll@skia.org Roll Flutter (stable) from fcf2c11 to 077b4a4 (5 revisions) (flutter/packages#9585) 2025-07-09 engine-flutter-autoroll@skia.org Roll Flutter from adffe24 to ac12f66 (28 revisions) (flutter/packages#9584) 2025-07-09 malo.allee@gmail.com [video_player] Add html 5 video poster support (thumbnail) as a VideoPlayerWebOptions (flutter/packages#8940) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assertion caused a crash with hot restart if a Flutter method call happened at the same time. Changing this to
NSLogalso allows logging failures when in release mode.Fixes flutter/flutter#170643
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3