deps: Add missing peer dependencies #16751
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
485df2e to
d477e77
Compare
size-limit report 📦
|
c752ad0 to
25687c2
Compare
❌ Unsupported file formatUpload processing failed due to unsupported file format. Please review the parser error message:
For more help, visit our troubleshooting guide. |
This adds missing peer dependencies that yarn complains about. Nothing should change, fundamentally.
f66c60e to
8e4e86b
Compare
mydea
commented
Jun 27, 2025
| @@ -59,7 +59,6 @@ sentryTest('should add resource spans to pageload transaction', async ({ getLoca | |||
|
|
|||
| const expectedScripts = [ | |||
| '/init.bundle.js', | |||
| '/subject.bundle.js', | |||
There was a problem hiding this comment.
this (subject) is not defined for this test, apparently some changed webpack version emits or does not emit the empty file anymore, but this should be OK.
mydea
commented
Jun 27, 2025
| "@nestjs/common": "11.0.16", | ||
| "@nestjs/core": "10.4.6", | ||
| "@nestjs/platform-express": "10.4.6", | ||
| "@nestjs/common": "11.1.3", |
There was a problem hiding this comment.
bumping & aligning to latest as that fixes some transitive dependency security issue.
mydea
commented
Jun 27, 2025
| @@ -71,7 +71,7 @@ | |||
| "ember-source": "~4.12.4", | |||
| "ember-template-lint": "~4.16.1", | |||
| "eslint-plugin-ember": "11.9.0", | |||
| "eslint-plugin-n": "16.0.1", | |||
| "eslint-plugin-n": "15.0.0", | |||
There was a problem hiding this comment.
downgrading because this actually requires eslint 8
mydea
commented
Jun 27, 2025
| @@ -1,7 +1,7 @@ | |||
| import type { ClientOptions, Context } from '@sentry/core'; | |||
| import { captureException, getClient, getTraceMetaTags, logger } from '@sentry/core'; | |||
| import type { VueOptions } from '@sentry/vue/src/types'; | |||
| import type { CapturedErrorContext } from 'nitropack'; | |||
| import type { CapturedErrorContext } from 'nitropack/types'; | |||
There was a problem hiding this comment.
this apparently changed in a newer nitropack version 😭
mydea
commented
Jun 27, 2025
| @@ -6,7 +6,7 @@ export type RollupConfig = { | |||
| plugins: unknown[]; | |||
| }; | |||
|
|
|||
| export type SolidStartInlineConfig = Parameters<typeof defineConfig>[0]; | |||
| export type SolidStartInlineConfig = NonNullable<Parameters<typeof defineConfig>[0]>; | |||
There was a problem hiding this comment.
type is now possible undefined, which leads to problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds missing peer dependencies that yarn complains about. Nothing should change, fundamentally.
Extracted this out of #16744