Skip to content

Fix units to cwysj pixi fountain #146599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Fix units to cwysj pixi fountain #146599

wants to merge 3 commits into from
+4 −0

Conversation

FredrikM97
Copy link
Contributor

Proposed change

The units for these sensors are currently set to minutes, but there is no option to change them to hours or days. For example, a filter that lasts about 30 days is shown as 42,786 minutes, which is difficult to interpret at a glance.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • [ x Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tuya can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tuya Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

frenck
frenck requested changes Jul 3, 2025
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See review comment on the code.

homeassistant/components/tuya/sensor.py
@@ -314,25 +314,29 @@ class TuyaSensorEntityDescription(SensorEntityDescription):
device_class=SensorDeviceClass.DURATION,
state_class=SensorStateClass.MEASUREMENT,
entity_registry_enabled_default=False,
native_unit_of_measurement=UnitOfTime.SECONDS,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forcing the unit of measurement in Tuya in general isn't correct. The units are supposed to be provided by the API.

Forcing this, maybe break it for others.

Is there something else wrong? Can you share the diagnostics for your device?

../Frenck

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tuya-01JZDKKN56VHBFSDV0GQG5B3N2-PIXI Smart Drinking Fountain-f85737e71a902748bca73adcdc572a0c.json

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2025-07-05 at 17 42 36
Seems like it is delivering minutes, we need to take into account.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also picture of it:
image
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I create an issue for it or what do you suggest? Is this a bug or something missing for the configuration of the device?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Frenck - it sounds like a bug on the device, not on the integration.
You may need to create a separate template entity to "fix" the value.

@home-assistant
Copy link

home-assistant bot commented Jul 3, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft July 3, 2025 21:02
@epenet epenet mentioned this pull request Jul 7, 2025
Merged
19 tasks
@FredrikM97 FredrikM97 mentioned this pull request Jul 12, 2025
Merged
19 tasks
@epenet
Copy link
Contributor

epenet commented Jul 16, 2025 •
edited
Loading

@FredrikM97 could you test latest dev + #148596 and see if that fixes your issue?

@epenet
Copy link
Contributor

epenet commented Jul 16, 2025

@FredrikM97 #148596 has been accepted and merged.
Can you please test latest dev and check if this is still needed?

@FredrikM97
Copy link
Contributor Author

@epenet Thank you. Will review it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck requested changes

@epenet epenet epenet left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
bugfix cla-signed integration: tuya Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FredrikM97 @epenet @frenck
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy