Skip to content

Fix units to cwysj pixi fountain #146599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
+4 −0
Draft

Fix units to cwysj pixi fountain #146599

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23f46e1
Fix units to cwysj pixi fountain
FredrikM97 Jun 12, 2025
0da40b9
Merge branch 'dev' into fix/cwysj/fix_to_cwysj_units
FredrikM97 Jun 12, 2025
60ba673
Merge branch 'dev' into fix/cwysj/fix_to_cwysj_units
FredrikM97 Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix units to cwysj pixi fountain
  • Loading branch information
@FredrikM97
FredrikM97 committed Jun 12, 2025
commit 23f46e19ff26319d4f645e62e8899c37b4aeae1e
4 changes: 4 additions & 0 deletions homeassistant/components/tuya/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,25 +314,29 @@ class TuyaSensorEntityDescription(SensorEntityDescription):
device_class=SensorDeviceClass.DURATION,
state_class=SensorStateClass.MEASUREMENT,
entity_registry_enabled_default=False,
native_unit_of_measurement=UnitOfTime.SECONDS,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forcing the unit of measurement in Tuya in general isn't correct. The units are supposed to be provided by the API.

Forcing this, maybe break it for others.

Is there something else wrong? Can you share the diagnostics for your device?

../Frenck

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tuya-01JZDKKN56VHBFSDV0GQG5B3N2-PIXI Smart Drinking Fountain-f85737e71a902748bca73adcdc572a0c.json

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2025-07-05 at 17 42 36
Seems like it is delivering minutes, we need to take into account.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also picture of it:
image
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I create an issue for it or what do you suggest? Is this a bug or something missing for the configuration of the device?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Frenck - it sounds like a bug on the device, not on the integration.
You may need to create a separate template entity to "fix" the value.

),
TuyaSensorEntityDescription(
key=DPCode.PUMP_TIME,
translation_key="pump_time",
device_class=SensorDeviceClass.DURATION,
state_class=SensorStateClass.MEASUREMENT,
native_unit_of_measurement=UnitOfTime.MINUTES,
),
TuyaSensorEntityDescription(
key=DPCode.FILTER_DURATION,
translation_key="filter_duration",
device_class=SensorDeviceClass.DURATION,
state_class=SensorStateClass.MEASUREMENT,
native_unit_of_measurement=UnitOfTime.MINUTES,
),
TuyaSensorEntityDescription(
key=DPCode.WATER_TIME,
translation_key="water_time",
device_class=SensorDeviceClass.DURATION,
state_class=SensorStateClass.MEASUREMENT,
entity_registry_enabled_default=False,
native_unit_of_measurement=UnitOfTime.MINUTES,
),
),
# Air Quality Monitor
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy