Use suggested unit of measurement in tuya #148599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes custom unit conversion logic from the Tuya integration now that the base number and sensor platforms handle conversions automatically. Key changes include:
- Dropped
conversion_unitandconversion_fnfromUnitOfMeasurementdefinitions. - Simplified sensor and number entities to only scale raw values (no per-unit conversion).
- Updated snapshots to reflect the change in unit (
A→mA), precision, and state values.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/components/tuya/snapshots/test_sensor.ambr | Updated expected unit, precision, and state in snapshot tests. |
| homeassistant/components/tuya/sensor.py | Removed custom conversion logic and self._uom attribute. |
| homeassistant/components/tuya/number.py | Mirrored simplification of conversion logic for number entities. |
| homeassistant/components/tuya/const.py | Eliminated conversion_unit and conversion_fn from unit models. |
Comments suppressed due to low confidence (2)
homeassistant/components/tuya/sensor.py:1418
- [nitpick] The local variable
uomis concise but may be unclear and shadows the removedself._uomattribute. Consider renaming it to something likeunit_metaorunit_infofor better clarity.
uom = uoms.get(self.native_unit_of_measurement) or uoms.get(
homeassistant/components/tuya/number.py:385
- Consider adding tests for number entities to verify that
native_valueandnative_unit_of_measurementremain correct after removing custom conversion logic, covering both integer and float cases.
uom = uoms.get(self.native_unit_of_measurement) or uoms.get(
19 tasks
epenet
commented
Jul 11, 2025
19 tasks
6341cd9 to
c945f5e
Compare
frenck
approved these changes
Jul 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Custom unit conversions were added as part of #57913 before automatic unit conversions got implemented by the base number and sensor platforms.
Use
suggested_unit_of_measurementinsteadPreliminary PR for #148596
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: