Skip to content

WIP: 3.3.0 release #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

WIP: 3.3.0 release #898

wants to merge 7 commits into from

Conversation

JonathanHuot
Copy link
Member

Dear community, upstreams & downstream consumers @evonove, @masci, @singingwolfboy & al,
Please check if this 3.3.0 release is working with your projects.
Unless any major issues, this will go out soon,

@JonathanHuot JonathanHuot changed the title 3.3.0 release WIP: 3.3.0 release May 14, 2025
@JonathanHuot JonathanHuot mentioned this pull request May 14, 2025
Open
@JonathanHuot
Copy link
Member Author

Put on hold until #899 is resolved.

@pennersr
Copy link

I have a test case that works fine with 3.2.2, but fails when using:

git+https://github.com/oauthlib/oauthlib@dab6a5ae1830ddd8a79c1e9687f63508eae60b57

An assert starts failing here -- when refreshing the token:

https://codeberg.org/allauth/django-allauth/src/branch/main/allauth/idp/oidc/tests/test_views.py#L430

The failure is as follows:

FAILED allauth/idp/oidc/tests/test_views.py::test_refresh_token - AssertionError: assert {'access_token': 'P3lWEna6Z2HPjDbKUx2JqtcadIePjo0PcLAW8O3C_B1gmeNZCM3uOfob-EwkkeWj0SdxbrudyETDulmAzrbx-A', 'expires_in': 3600, 'token_type': 'Bearer', 'scope': 'openid profile', 'refresh_token': 's6CAVWD7IF46vVl6xO9BRnEOyFnhbuzwIQZM3XQw6k4vYHieXX8-wcgcwV_iBvjqJU-T3ay2niAiDmPfeZ8cQA', 'id_token': 'eyJhbGciOiJSUzI1NiIsImtpZCI6InhWYkt1bXg1X2o0SlduRGE0TXc4M1IyWk5SNDEtRHhnVDgxcGxJWXZNLWMiLCJ0eXAiOiJKV1QifQ.eyJhdWQiOiJmMmIxMDI0ZjE5MjI0MWFhYjk1OTZlZWZkMzY2MTk4OSIsImlhdCI6MTc0Nzc2NDQyOSwiYXRfaGFzaCI6ImdzUlA0OXNQYy1GM1kyTll2NXVRMEEiLCJpc3MiOiJodHRwOi8vdGVzdHNlcnZlciIsImV4cCI6MTc0Nzc2NDcyOSwianRpIjoiNDg2MzdjYjRiYTcxNDY0OGEzYThjZTkxNzQ4ZjYyMTciLCJzdWIiOiIxIiwicHJlZmVycmVkX3VzZXJuYW1lIjoiYjJhN2JhYzcxOGM2NDk3MjgwZTk1N2FhZjNmNGQ1NjYifQ.L7P5M0brhtkGN1n_ocrtod-wHj_AroMVkb6z30vJIR8eF2rbzipYJgmbeEIVEfcDlAJR351iI8Z79PQcSg0C_sBKWeODcNd22Y0duV51TR5mFyU9mA2jJhQDA2pxaKMEgTcDtnboxBW4qgndnsr0DPEVGEyg3N7vNgheefdlxg0eJItQTzS4lC_o_kK9sffUocEFGxGAsXFea3rSZ4-RiMOB_Xv5apKmLuO98ZFx-eC_B6JY4QjTtDlWPrjQFap_Y9ZYgcwsJvdtkHw8X-OYDvJ6ovlaY-JK59DFYvGgHmFnQ6M79ENw0J71B1WzZMMege9aJcpTXfI5UICfHk3X9A'} == {'access_token': <ANY>, 'expires_in': 3600, 'refresh_token': <ANY>, 'scope': 'openid profile', 'token_type': 'Bearer'}
  
  Common items:
  {'access_token': 'P3lWEna6Z2HPjDbKUx2JqtcadIePjo0PcLAW8O3C_B1gmeNZCM3uOfob-EwkkeWj0SdxbrudyETDulmAzrbx-A',
   'expires_in': 3600,
   'refresh_token': 's6CAVWD7IF46vVl6xO9BRnEOyFnhbuzwIQZM3XQw6k4vYHieXX8-wcgcwV_iBvjqJU-T3ay2niAiDmPfeZ8cQA',
   'scope': 'openid profile',
   'token_type': 'Bearer'}
  Left contains 1 more item:
  {'id_token': 'eyJhbGciOiJSUzI1NiIsImtpZCI6InhWYkt1bXg1X2o0SlduRGE0TXc4M1IyWk5SNDEtRHhnVDgxcGxJWXZNLWMiLCJ0eXAiOiJKV1QifQ.eyJhdWQiOiJmMmIxMDI0ZjE5MjI0MWFhYjk1OTZlZWZkMzY2MTk4OSIsImlhdCI6MTc0Nzc2NDQyOSwiYXRfaGFzaCI6ImdzUlA0OXNQYy1GM1kyTll2NXVRMEEiLCJpc3MiOiJodHRwOi8vdGVzdHNlcnZlciIsImV4cCI6MTc0Nzc2NDcyOSwianRpIjoiNDg2MzdjYjRiYTcxNDY0OGEzYThjZTkxNzQ4ZjYyMTciLCJzdWIiOiIxIiwicHJlZmVycmVkX3VzZXJuYW1lIjoiYjJhN2JhYzcxOGM2NDk3MjgwZTk1N2FhZjNmNGQ1NjYifQ.L7P5M0brhtkGN1n_ocrtod-wHj_AroMVkb6z30vJIR8eF2rbzipYJgmbeEIVEfcDlAJR351iI8Z79PQcSg0C_sBKWeODcNd22Y0duV51TR5mFyU9mA2jJhQDA2pxaKMEgTcDtnboxBW4qgndnsr0DPEVGEyg3N7vNgheefdlxg0eJItQTzS4lC_o_kK9sffUocEFGxGAsXFea3rSZ4-RiMOB_Xv5apKmLuO98ZFx-eC_B6JY4QjTtDlWPrjQFap_Y9ZYgcwsJvdtkHw8X-OYDvJ6ovlaY-JK59DFYvGgHmFnQ6M79ENw0J71B1WzZMMege9aJcpTXfI5UICfHk3X9A'}
  
  Full diff:
    {
  -     'access_token': <ANY>,
  +     'access_token': 'P3lWEna6Z2HPjDbKUx2JqtcadIePjo0PcLAW8O3C_B1gmeNZCM3uOfob-EwkkeWj0SdxbrudyETDulmAzrbx-A',
        'expires_in': 3600,
  -     'refresh_token': <ANY>,
  +     'id_token': 'eyJhbGciOiJSUzI1NiIsImtpZCI6InhWYkt1bXg1X2o0SlduRGE0TXc4M1IyWk5SNDEtRHhnVDgxcGxJWXZNLWMiLCJ0eXAiOiJKV1QifQ.eyJhdWQiOiJmMmIxMDI0ZjE5MjI0MWFhYjk1OTZlZWZkMzY2MTk4OSIsImlhdCI6MTc0Nzc2NDQyOSwiYXRfaGFzaCI6ImdzUlA0OXNQYy1GM1kyTll2NXVRMEEiLCJpc3MiOiJodHRwOi8vdGVzdHNlcnZlciIsImV4cCI6MTc0Nzc2NDcyOSwianRpIjoiNDg2MzdjYjRiYTcxNDY0OGEzYThjZTkxNzQ4ZjYyMTciLCJzdWIiOiIxIiwicHJlZmVycmVkX3VzZXJuYW1lIjoiYjJhN2JhYzcxOGM2NDk3MjgwZTk1N2FhZjNmNGQ1NjYifQ.L7P5M0brhtkGN1n_ocrtod-wHj_AroMVkb6z30vJIR8eF2rbzipYJgmbeEIVEfcDlAJR351iI8Z79PQcSg0C_sBKWeODcNd22Y0duV51TR5mFyU9mA2jJhQDA2pxaKMEgTcDtnboxBW4qgndnsr0DPEVGEyg3N7vNgheefdlxg0eJItQTzS4lC_o_kK9sffUocEFGxGAsXFea3rSZ4-RiMOB_Xv5apKmLuO98ZFx-eC_B6JY4QjTtDlWPrjQFap_Y9ZYgcwsJvdtkHw8X-OYDvJ6ovlaY-JK59DFYvGgHmFnQ6M79ENw0J71B1WzZMMege9aJcpTXfI5UICfHk3X9A',
  +     'refresh_token': 's6CAVWD7IF46vVl6xO9BRnEOyFnhbuzwIQZM3XQw6k4vYHieXX8-wcgcwV_iBvjqJU-T3ay2niAiDmPfeZ8cQA',
        'scope': 'openid profile',
        'token_type': 'Bearer',
    }
======================================================== 1 failed, 23 deselected, 7 warnings in 1.67s ========================================================

So, with the new version an additional id_token key appears which was not there before.

@JonathanHuot
Copy link
Member Author

Might be related to changes added since 7e69a15

Based on the commit only, if openid is present in scope, you will have an id_token by default which seems to be the natural expected behavior.
Let me dig into what we have done for these pre_configured servers and see if they are accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonathanHuot @pennersr
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy