Add proper return type to user context json serialize #250
Conversation
The following indirect deprecation notice is popping up when calling OptimizelyUserContext::jsonSerialize in php 8+: 1x: Method "JsonSerializable::jsonSerialize()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "Optimizely\OptimizelyUserContext" now to avoid errors or add an explicit @return annotation to suppress this message.
|
Hi Samy, I apologize for the extremely prolonged reply and lack of acknowledgement. Thank you for raising this. I'll open an internal ticket to get reviewed with our team. |
|
I have created an internal ticket with our Developer Experience team (FSSDK-8940 for your reference) currently awaiting review. |
|
That's okay, thanks for picking this up. Not sure if you are the right person to ask, but is the team also going to make the Optimizely SDK php 8.2 ready? We are dropping the dependency for now since it is raising all kinds of issues that blocks our upgrade. Would love to add it again 😄 |
|
Hi @samybasset , I'll discuss with our Developer Experience team regarding making the Optimizely SDK compatible with PHP 8.2. I unfortunately can't comment on prioritization or timelines at the moment but will consult our team this week. I'll let you know as soon as I have more information. Thank you for your patience. |
|
Hi @samybasset , I'm happy to share that one of our developers is looking into technical feasibility of supporting PHP 8.2 now. I hope to give you an update in about 2 weeks at the end of our current sprint. We unfortunately still haven't been able to prioritize the original issue reported, but we have reviewed it as a team. I'll do my best to see if we can get it prioritized over the coming weeks and will update you accordingly. |
|
We've outlined the requirements for our developer to accomplish (pretty simple) update. Of course, we have to walk this properly through our development and release SOP. Thanks for hanging in there with us. |
|
Hi @samybasset, thanks for hanging on there. We just released a patch which should cover your change request please look into it and let us know how it goes. |
|
@samybasset We've released a version that includes your suggestion from this PR. Thanks for the help. |
Summary
The following indirect deprecation notice is popping up when calling OptimizelyUserContext::jsonSerialize in php 8+:
To remove the notice, the proper return type is added.