-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Refactor how py-script are executed, kill scriptQueue store, introduce pyExec #881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
cbedd43
move the code for registering ES modules into main.ts, and add a big …
antocuni 667ed3e
start to move the logic for executing python code into pyExec
antocuni f31274a
kill unused code
antocuni 41e6deb
Introduce pytest --no-fake-server.
antocuni 507466a
remove the <string> cast, it's not necessary
antocuni f8888d3
kill the support for std-err: it was unused and it will be refactored
antocuni b1cd5a2
kill support for std-out as well
antocuni 1134c84
kill kill kill
antocuni b3fc5bc
add a pytest option --dev which is like --headed but also automatical…
antocuni 179befd
typo
antocuni 14c6537
improve this test and mark it as xfail, see issue #878
antocuni 33b03a4
add a failing test
antocuni 9f75fc8
kill more unneeded code and adapt the tests accordingly
antocuni 591534c
kill guidGenerator and use sequential numbers instead, they are much …
antocuni e2f4b8f
refactor pyExec to take an HTMLElement instead of an id
antocuni c8ba605
make PyScript a standalone class and remove the intheritance from Bas…
antocuni 76280c4
simplify this test. With test_pyscript_hello we just want to check th…
antocuni dcdb020
woooo, finally kill the last remaining store, scriptQueue. Instead of…
antocuni dca2ffb
add a test for <py-script src=...> and implement the functionality
antocuni 69d03aa
we no longer need the shadow root for <py-script>
antocuni 4999566
add the logic to display exceptions which are raised inside <py-scrip…
antocuni 6cd5178
Merge remote-tracking branch 'origin/main' into antocuni/kill-script-…
antocuni 50c872f
kill this test, addToOutput was killed
antocuni eaacc21
kill pyscript.test.ts: it doesn't make sense to unit-test it at this …
antocuni d3c68ea
test_multiple_async_display is not really about async and it's not ab…
antocuni afdf355
PyLoader doesn't have to inherit from BaseEvalElement
antocuni b3d43d6
py-title doesn't have to inherit from BaseEvalElement
antocuni ce1104b
PyButton doesn't have to inherit from BaseEvalElement
antocuni e345ed5
PyInputBox doesn't have to inherit from BaseEvalElement
antocuni 5d46042
fix the PyTitle tests
antocuni f999e62
fix the pyinputbox and pybutton unit tests
antocuni ecac29a
add a comment
antocuni 3eb07da
remove outdate comment
antocuni b796d33
Merge remote-tracking branch 'origin/main' into antocuni/kill-script-…
antocuni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix the PyTitle tests
- Loading branch information
commit 5d460424234e9d8199a7d878e26a25aa4788379a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.