Skip to content

Refactor how py-script are executed, kill scriptQueue store, introduce pyExec #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Oct 23, 2022
Merged

Refactor how py-script are executed, kill scriptQueue store, introduce pyExec #881

Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
cbedd43
move the code for registering ES modules into main.ts, and add a big …
antocuni Oct 21, 2022
667ed3e
start to move the logic for executing python code into pyExec
antocuni Oct 21, 2022
f31274a
kill unused code
antocuni Oct 21, 2022
41e6deb
Introduce pytest --no-fake-server.
antocuni Oct 21, 2022
507466a
remove the <string> cast, it's not necessary
antocuni Oct 21, 2022
f8888d3
kill the support for std-err: it was unused and it will be refactored
antocuni Oct 21, 2022
b1cd5a2
kill support for std-out as well
antocuni Oct 21, 2022
1134c84
kill kill kill
antocuni Oct 21, 2022
b3fc5bc
add a pytest option --dev which is like --headed but also automatical…
antocuni Oct 22, 2022
179befd
typo
antocuni Oct 22, 2022
14c6537
improve this test and mark it as xfail, see issue #878
antocuni Oct 22, 2022
33b03a4
add a failing test
antocuni Oct 22, 2022
9f75fc8
kill more unneeded code and adapt the tests accordingly
antocuni Oct 22, 2022
591534c
kill guidGenerator and use sequential numbers instead, they are much …
antocuni Oct 22, 2022
e2f4b8f
refactor pyExec to take an HTMLElement instead of an id
antocuni Oct 22, 2022
c8ba605
make PyScript a standalone class and remove the intheritance from Bas…
antocuni Oct 22, 2022
76280c4
simplify this test. With test_pyscript_hello we just want to check th…
antocuni Oct 22, 2022
dcdb020
woooo, finally kill the last remaining store, scriptQueue. Instead of…
antocuni Oct 22, 2022
dca2ffb
add a test for <py-script src=...> and implement the functionality
antocuni Oct 22, 2022
69d03aa
we no longer need the shadow root for <py-script>
antocuni Oct 22, 2022
4999566
add the logic to display exceptions which are raised inside <py-scrip…
antocuni Oct 22, 2022
6cd5178
Merge remote-tracking branch 'origin/main' into antocuni/kill-script-…
antocuni Oct 22, 2022
50c872f
kill this test, addToOutput was killed
antocuni Oct 22, 2022
eaacc21
kill pyscript.test.ts: it doesn't make sense to unit-test it at this …
antocuni Oct 22, 2022
d3c68ea
test_multiple_async_display is not really about async and it's not ab…
antocuni Oct 22, 2022
afdf355
PyLoader doesn't have to inherit from BaseEvalElement
antocuni Oct 22, 2022
b3d43d6
py-title doesn't have to inherit from BaseEvalElement
antocuni Oct 22, 2022
ce1104b
PyButton doesn't have to inherit from BaseEvalElement
antocuni Oct 22, 2022
e345ed5
PyInputBox doesn't have to inherit from BaseEvalElement
antocuni Oct 22, 2022
5d46042
fix the PyTitle tests
antocuni Oct 22, 2022
f999e62
fix the pyinputbox and pybutton unit tests
antocuni Oct 22, 2022
ecac29a
add a comment
antocuni Oct 22, 2022
3eb07da
remove outdate comment
antocuni Oct 23, 2022
b796d33
Merge remote-tracking branch 'origin/main' into antocuni/kill-script-…
antocuni Oct 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
kill pyscript.test.ts: it doesn't make sense to unit-test it at this … 
…level because you would need to mock the whole Runtime, and you would end up testing the mock instead of something actually useful. PyScript is battle-tested a lot by integration tests
  • Loading branch information
@antocuni
antocuni committed Oct 22, 2022
commit eaacc2189c545dcb563c1dd72f645b90641496b9
66 changes: 0 additions & 66 deletions pyscriptjs/tests/unit/pyscript.test.ts
View file
Open in desktop

This file was deleted.

pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy