gh-130425: Add "Did you mean [...]" suggestions for del obj.attr
#130799
Conversation
del obj.attr
Lib/test/test_traceback.py
Outdated
| self.assertIn("'bluch'", self.get_suggestion(A(), '_luch')) | ||
| self.assertIn("'bluch'", self.get_suggestion(A(), '_bluch')) | ||
| obj = A() | ||
| if operation == "getattr": |
There was a problem hiding this comment.
Sorry, I don't quite like the current design :(
It would be even more complex, when we add setattr tests (btw, I think that they should also be added in this PR).
Can we instead create a base class out of existing testcase? And then create three subclasses which would look like so:
class GetattrSuggestionsTests(BaseSuggestionsTests, unittest.TestCase):
def get_suggestion(self, obj, name):
# get suggestions using `getattr`
class SetattrSuggestionsTests(BaseSuggestionsTests, unittest.TestCase):
def get_suggestion(self, obj, name):
# get suggestions using `setattr`
# the same for `delattr`There was a problem hiding this comment.
I'll first refactor the tests as per your suggestion, and keep that as a separate commit.
I was unsure of adding setattr suggestion tests to this PR because:
- The concerning issue was raised for adding delattr suggestions alone.
- There are multiple ways to simulate an AttributeError for setattr (custom
__slots__,@propertyetc.), and I felt it would be better to discuss the appropriate testing mechanism in a separate PR.
There was a problem hiding this comment.
I have made the requested changes as per the refactor request. Kindly review the PR again.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I would have actually expected that to be a feature and not a fix actually!
I actually always combined my fixes with my tests to check indeed that my fix is correct. Same for features. |
|
All commit authors signed the Contributor License Agreement. |
There was a problem hiding this comment.
The interface is now a bit too nested. We have many nested classes and this is not the best I think. I suggest the following:
class AttributeSuggestions:
def get_suggestion(...): ...
class GetattrSuggestions(AttributeSuggestions): ...
class DelattrSuggestions(AttributeSuggestions): ...
class SetattrSuggestions(AttributeSuggestions): ...And then create the additional classes as you did that inherit from different mixins. But we don't need to touch SuggestionFormattingTestBase for delattr/getattr/hasattr etc. We can just make a separate class. If there is a common interface between SuggestionFormattingTestBase and those classes, make an even top class, say SuggestionFormattingTestBaseParent and SuggestionFormattingTestBase would inherit from it. That way you can share a common interface (I don't know if I'm clear enough).
0b58966 to
0ecb6d8
Compare
|
Please avoid force-pushing. I'm going to close this one as many people were notified and suggeset you to create a fresh PR. |
Merges PR #130427 implementing delattr suggestions by @sobolevn and PR #130455 adding tests for the feature by @Pranjal095
Note: This PR's sole purpose is to combine the feature implementation from PR #130427 with the test cases from PR #130455. All original commits have been preserved to retain proper authorship.