-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arithmetic_side_effects, redundant_pub_crate should not warn external macros #10636
Labels
C-bug
Category: Clippy is not doing the correct thing
I-false-positive
Issue: The lint was triggered on code it shouldn't have
Comments
Erigara
added
C-bug
Category: Clippy is not doing the correct thing
I-false-positive
Issue: The lint was triggered on code it shouldn't have
labels
Apr 12, 2023
5 tasks
5 tasks
The Clippy still emits a
|
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 12, 2025
Some widely used crates, such as `pin-project-lite`, make use of a `pub(crate)` construct in a private module inside a public macro. This makes unrelated project trigger the lint. There is also an unfortunate situation for Clippy itself: when a new version of `pin-project-lite` or similar lint-trigerring crates is released, those lints which can be found in hundreds of occurrences in dependent crates will change, and appear as diffs in unrelated Clippy PR because the base lintcheck run will be cached with the ancient release of the crates. We currently have the situation [here](https://github.com/rust-lang/rust-clippy/actions/runs/12635410895?pr=13851#user-content-redundant-pub-crate-removed), which 219 lints removed and 219 lints added because of a `pin-project-lite` version change between runs, and the fact that `redundant_pub_crate` triggers on external macros. Also: - Fix #10636 - Fix #12213 changelog: [`redundant_pub_crate`]: do not trigger on external macros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-bug
Category: Clippy is not doing the correct thing
I-false-positive
Issue: The lint was triggered on code it shouldn't have
Summary
arithmetic_side_effects and redundant_pub_crate currently warns on code generated by external macros (in my case
tokio::select!
).Lint Name
arithmetic_side_effects, redundant_pub_crate
Reproducer
I tried this code:
I saw this happen:
I expected to see this happen: compile without errors.
Version
Additional Labels
No response
The text was updated successfully, but these errors were encountered: