Apply php-cs-fixer fix --rules nullable_type_declaration_for_default_null_value #53612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @keradus FYI I think we should also make the null default value explicit for untyped properties. What's the fixer for that? 👼 |
fancyweb
reviewed
Jan 23, 2024
| @@ -0,0 +1,2 @@ | |||
| # Apply php-cs-fixer fix --rules nullable_type_declaration_for_default_null_value | |||
| f4118e110a46de3ffb799e7d79bf15128d1646ea | |||
There was a problem hiding this comment.
|
I really prefer this way! Thanks 👍🏼 |
a0f56ce to
fb9fa26
Compare
Same here, this also makes diffs less noisy when converting to CPP 👏 |
|
Now merged up to 7.1, help wanted to fix tests :) |
|
@nicolas-grekas , if you wonder about such fixer, I don't think it exists, feel encouraged to drop the PR for it <?php
class X {
- public string $name;
+ public ?string $name;
} |
- public string $name;
+ public ?string $name;Be careful this wouldn't be equivalent! So no, I won't want this rule anytime :) |
Merged
lyrixx
added a commit
to lyrixx/PHP-CS-Fixer
that referenced
this pull request
Feb 6, 2024
weaverryan
added a commit
to symfony/ux
that referenced
this pull request
Feb 7, 2024
This PR was merged into the 2.x branch. Discussion ---------- CS Update | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Issues | n/a | License | MIT Updates to the latest Symfony CS rules. Refs: PHP-CS-Fixer/PHP-CS-Fixer#7773 & symfony/symfony#53612 Commits ------- aad4e17 minor: update cs
symfony-splitter
pushed a commit
to symfony/ux-turbo
that referenced
this pull request
Feb 7, 2024
This PR was merged into the 2.x branch. Discussion ---------- CS Update | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Issues | n/a | License | MIT Updates to the latest Symfony CS rules. Refs: PHP-CS-Fixer/PHP-CS-Fixer#7773 & symfony/symfony#53612 Commits ------- aad4e17d minor: update cs
symfony-splitter
pushed a commit
to symfony/ux-twig-component
that referenced
this pull request
Feb 7, 2024
This PR was merged into the 2.x branch. Discussion ---------- CS Update | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Issues | n/a | License | MIT Updates to the latest Symfony CS rules. Refs: PHP-CS-Fixer/PHP-CS-Fixer#7773 & symfony/symfony#53612 Commits ------- aad4e17d minor: update cs
symfony-splitter
pushed a commit
to symfony/stimulus-bundle
that referenced
this pull request
Feb 7, 2024
This PR was merged into the 2.x branch. Discussion ---------- CS Update | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Issues | n/a | License | MIT Updates to the latest Symfony CS rules. Refs: PHP-CS-Fixer/PHP-CS-Fixer#7773 & symfony/symfony#53612 Commits ------- aad4e17d minor: update cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is important to make on 5.4 because it will likely fix a deprecation in a future PHP version, see https://externals.io/message/122214
(do not squash while merging)