Skip to content

uprev cargo dependencies #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025
Merged

uprev cargo dependencies #957

merged 3 commits into from
May 22, 2025

Conversation

samuelcolvin
Copy link
Contributor

No description provided.

@axxel
Copy link
Collaborator

axxel commented May 21, 2025

So you are basically increasing the minimum required version of the image crate without changing anything that would depend on any new features of that crate. What is your motivation / gain?

@samuelcolvin
Copy link
Contributor Author

The motivation/gain is that I'm using other dependencies that rely on images "0.25.*", so I'm generating an image using that version. Without this change I can't use those images with this crate.

I've relaxed the constraint to avoid an upper bound, which is generally considered good practice, although seems somewhat less common in Rust than it is in Python.

@axxel
Copy link
Collaborator

axxel commented May 21, 2025

Without this change I can't use those images with this crate.

Oh that is news to me. I thought the specified versions are implicitly treated as the minimum, not an exact match. After some memory refreshing I believe your latest choice is the best one from all the possibilities.

Can you please remove the unrelated/whitespace changes from your PR and set the package version to version = "0.4.2"?

@samuelcolvin
Copy link
Contributor Author

The white space changes were made by the auto-formatter, I'd recommend you made them anyway, but I've reverted them to get this merged.

@axxel
Copy link
Collaborator

axxel commented May 22, 2025

Thanks. I'll uptick the version of the package itself the next time I push a release. What is "the auto-formater" you are referring to here?

@axxel axxel merged commit a5bebca into zxing-cpp:master May 22, 2025
18 checks passed
@samuelcolvin
Copy link
Contributor Author

The white space changes were made by the auto-formatter, I'd recommend you made them anyway, but I've reverted them to get this merged.

many IDEs, including zed, format files (e.g. using prettier) automatically on save, which is why the changed happened.

@axxel
Copy link
Collaborator

axxel commented May 22, 2025

many IDEs, including zed, format files (e.g. using prettier) automatically on save, which is why the changed happened.

Sure but that then becomes rather user specific. My first interpretation of your statement was that this layout is "the standard". Anyway, thanks for the contribution.

@samuelcolvin
Copy link
Contributor Author

samuelcolvin commented May 22, 2025

well, prettier is:

  1. widely used
  2. following the toml standard - A style guide for toml? toml-lang/toml#608

This doesn't matter much, but it's not ambiguous what "right" is.

axxel added a commit that referenced this pull request May 22, 2025
Done with Even Better TOML plugin of VSCode, seems to agree with #957.
@axxel
Copy link
Collaborator

axxel commented May 22, 2025

My VSCode had an extension installed that agreed with your style... So on to the next adventure ;).

May I ask what you are using the rust wrapper for? Reader and/or Writer?

@samuelcolvin
Copy link
Contributor Author

reading QR codes, see https://github.com/samuelcolvin/qrcam/blob/main/src/decode.rs

Currently a WIP, but the idea is to have an app for reading QR codes using the webcam on macos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy