-
-
Notifications
You must be signed in to change notification settings - Fork 464
uprev cargo dependencies #957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So you are basically increasing the minimum required version of the image crate without changing anything that would depend on any new features of that crate. What is your motivation / gain? |
The motivation/gain is that I'm using other dependencies that rely on images "0.25.*", so I'm generating an image using that version. Without this change I can't use those images with this crate. I've relaxed the constraint to avoid an upper bound, which is generally considered good practice, although seems somewhat less common in Rust than it is in Python. |
Oh that is news to me. I thought the specified versions are implicitly treated as the minimum, not an exact match. After some memory refreshing I believe your latest choice is the best one from all the possibilities. Can you please remove the unrelated/whitespace changes from your PR and set the package version to |
The white space changes were made by the auto-formatter, I'd recommend you made them anyway, but I've reverted them to get this merged. |
Thanks. I'll uptick the version of the package itself the next time I push a release. What is "the auto-formater" you are referring to here? |
many IDEs, including zed, format files (e.g. using prettier) automatically on save, which is why the changed happened. |
Sure but that then becomes rather user specific. My first interpretation of your statement was that this layout is "the standard". Anyway, thanks for the contribution. |
well, prettier is:
This doesn't matter much, but it's not ambiguous what "right" is. |
Done with Even Better TOML plugin of VSCode, seems to agree with #957.
My VSCode had an extension installed that agreed with your style... So on to the next adventure ;). May I ask what you are using the rust wrapper for? Reader and/or Writer? |
reading QR codes, see https://github.com/samuelcolvin/qrcam/blob/main/src/decode.rs Currently a WIP, but the idea is to have an app for reading QR codes using the webcam on macos. |
No description provided.